move examples to WaterLily-Examples #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
|
This is showing up as breaking the CI. Is that just the code coverage? |
|
Yes, my bad, the documenter was using some stuff in |
|
Do we want to clean up the README since all of those examples are now in another repo? Maybe we can focus the WaterLily README and point them straight over to the tutorials? |
Here is a short version of the README. I've replaced all the examples with a simple circle flow tutorial. That's it...
marinlauber
commented
Aug 2, 2024
README.md
Outdated
| # don't forget to close the file | ||
| close(writer) | ||
| using CUDA | ||
| @assert CUDA.functional() # is your CUDA GPU working?? |
There was a problem hiding this comment.
Is that still useful? The extension does it when you load it already, right?
There was a problem hiding this comment.
On my machine at home, using CUDA doesn't throw any error, so the @assert is needed to stop people from following the example blindly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.