-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convective exit #74
Merged
Merged
Convective exit #74
Commits on Sep 7, 2023
-
marinlauber committed
Sep 7, 2023 Configuration menu - View commit details
-
Copy full SHA for 633557e - Browse repository at this point
Copy the full SHA 633557eView commit details -
initial convective exit commit
marinlauber committedSep 7, 2023 Configuration menu - View commit details
-
Copy full SHA for 6465360 - Browse repository at this point
Copy the full SHA 6465360View commit details -
marinlauber committed
Sep 7, 2023 Configuration menu - View commit details
-
Copy full SHA for 2d4787c - Browse repository at this point
Copy the full SHA 2d4787cView commit details
Commits on Oct 10, 2023
-
The main problem with the previous version were the `a.u .= 0` and `a.u ./= 2` lines in `mom_step!` which kept modifying the exit plane values. I changed these lines to only update the values inside the domain. I added an `flow.exit` to the struct and initialization functions and use this to trigger the convection exit behavior. The `apply!` function had the opposite problem - it WASN'T filling in the boundary value. Now it does. It also seemed weird to me that the convection exit value in Lotus was based on the old value at the boundary but the u* value (before projection) upstream. I'm not sure it matters much, but it seems more consistent to just use the old values in both places, so that's what it does now. Finally, I added a Lamp vortex dipole test case, which is nice since it should leave the exit without changing size or speed.
weymouth committedOct 10, 2023 Configuration menu - View commit details
-
Copy full SHA for 63b88be - Browse repository at this point
Copy the full SHA 63b88beView commit details
Commits on Oct 12, 2023
-
weymouth committed
Oct 12, 2023 Configuration menu - View commit details
-
Copy full SHA for cdb354c - Browse repository at this point
Copy the full SHA cdb354cView commit details
Commits on Oct 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9f1b1fe - Browse repository at this point
Copy the full SHA 9f1b1feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62793e0 - Browse repository at this point
Copy the full SHA 62793e0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.