Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convective exit #74

Merged
merged 7 commits into from
Oct 14, 2023
Merged

Commits on Sep 7, 2023

  1. initial Biot-Savart BC

    marinlauber committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    633557e View commit details
    Browse the repository at this point in the history
  2. initial convective exit commit

    marinlauber committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    6465360 View commit details
    Browse the repository at this point in the history
  3. removed old files

    marinlauber committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    2d4787c View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Working exit prototype

    The main problem with the previous version were the `a.u .= 0` and `a.u ./= 2` lines in `mom_step!` which kept modifying the exit plane values. I changed these lines to only update the values inside the domain.
    
    I added an `flow.exit` to the struct and initialization functions and use this to trigger the convection exit behavior.
    
    The `apply!` function had the opposite problem - it WASN'T filling in the boundary value. Now it does.
    
    It also seemed weird to me that the convection exit value in Lotus was based on the old value at the boundary but the u* value (before projection) upstream. I'm not sure it matters much, but it seems more consistent to just use the old values in both places, so that's what it does now.
    
    Finally, I added a Lamp vortex dipole test case, which is nice since it should leave the exit without changing size or speed.
    weymouth committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    63b88be View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Move to test

    weymouth committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    cdb354c View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Configuration menu
    Copy the full SHA
    9f1b1fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    62793e0 View commit details
    Browse the repository at this point in the history