Request to add custom SSL certificate verification #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malakhalifa0
changed the title
|
Hi @malakhalifa0, thanks for the PR! It looks like tests are failing because self.certificate_location is never set. Could you add an optional argument to the init of WattTimeBase for this? @xginn8 any thoughts on what the default value for that argument should be? |
Thanks for your feedback! For some reason self.certificate_location wasn't initialised in this branch, merging it with main updated the code properly. Let me know if the tests pass now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #24
Currently, watttime/api.py does not specify custom SSL certificate verification when making requests to the WattTime API, instead, it uses the system defaults. For enhanced security and compatibility with specific certificate requirements, we need to update the function to use a custom certificate location for SSL verification.
This would be really useful in the cases where we would need to trust a specific certificate and would improve the security and compatibility of the API login process.