Merge pull request #99 from ywy2090/feature-milestone2-gateway

fix mpc task not execute bug
WeBankBlockchain · Nov 25, 2024 · a5b817d · a5b817d
2 parents 77c138f + 02d5d90
commit a5b817d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 13 deletions.
diff --git a/cpp/wedpr-computing/ppc-mpc/src/MPCService.cpp b/cpp/wedpr-computing/ppc-mpc/src/MPCService.cpp
@@ -347,26 +347,31 @@ void MPCService::asyncRunMpcRpc(Json::Value const& request, RespFunc func)
         {  
             response["code"] = MPC_SUCCESS;
             response["message"] = "success";
+
+            MPC_LOG(INFO) << LOG_DESC("[MPCService][asyncRunMpcRpc]") << LOG_DESC("async run mpc submit job successfully")
+                      << LOG_KV("request", request.toStyledString())
+                      << LOG_KV("response", response.toStyledString());
+
+            // async run mpc job
+            m_threadPool->enqueue([self = weak_from_this(), jobInfo]() {
+                auto service = self.lock();
+                if (!service)
+                {
+                    MPC_LOG(ERROR) << LOG_DESC("[MPCService][asyncRunMpcRpc]") << LOG_DESC("async run mpc service is null");
+                    return;
+                }
+                service->runMpcRpcByJobInfo(jobInfo);
+            });
         }
         else 
         {
             response["code"] = MPC_DUPLICATED;
             response["message"] = "duplicated submit job";
-        }
 
-        MPC_LOG(INFO) << LOG_DESC("[MPCService][asyncRunMpcRpc]") << LOG_DESC("async run mpc submit job successfully")
+            MPC_LOG(INFO) << LOG_DESC("[MPCService][asyncRunMpcRpc]") << LOG_DESC("async run mpc duplicated submit job")
                       << LOG_KV("request", request.toStyledString())
                       << LOG_KV("response", response.toStyledString());
-
-        // async run mpc job
-        m_threadPool->enqueue([self = weak_from_this(), jobInfo]() {
-            auto service = self.lock();
-            if (!service)
-            {
-                return;
-            }
-            service->runMpcRpcByJobInfo(jobInfo);
-        });
+        }
     }
     catch (const std::exception& e)
     {

diff --git a/cpp/wedpr-computing/ppc-mpc/src/MPCService.h b/cpp/wedpr-computing/ppc-mpc/src/MPCService.h
@@ -34,7 +34,7 @@
 
 namespace ppc::mpc
 {
-class MPCService: std::enable_shared_from_this<MPCService>
+class MPCService: public std::enable_shared_from_this<MPCService>
 {
 public:
     using Ptr = std::shared_ptr<MPCService>;