Feature/webfinger (1 / X Pull requests for Activitypub support) #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huntertur
reviewed
Dec 21, 2024
| """Handle WebFinger requests.""" | ||
| resource = request.params.get('resource') | ||
| if not resource or not resource.startswith('acct:'): | ||
| raise WeasylError("Invalid resource parameter") |
There was a problem hiding this comment.
Sorry for taking so long to start to take a look at this. The string parameter that the constructor for WeasylError takes should match one of the keys of weasyl.errorcode.error_messages. The value for that key becomes the error message that is shown to the user when WeasylError is thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of probably many pull requests to add activitypub and hopefully activitystream support.
Webfinger will allow another activitypub server like mastodon to see if weasyl can "speak" activitypub it also can be used to lookup users although you will not be able to follow those, yet that will be one of the next pull requests, but all depend on this feature.
Next steps will be:
at that point weasyl would be ready to send stuff to the fediverse
inbox features would need to be discussed:
I have absolutely no idea how weasyl should render if someone from weasyl wants to follow someone on mastodon, but this isn't possible on wordpress either as far as I'm aware so maybe we don't need it that way.
I leave this as draft until we have discussed the feature here or on gitter.