Confirm more 'destructive' actions #1492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data-confirm
XMLHttpRequest
withfetch
in client-side submission favoriting logicI was not able to cleanly use
data-confirm
for unfavoriting a submission, since the nextsubmit
event handler, which does the web request to favorite or unfavorite the submission, will then immediately fire regardless of the user's choice for the confirmation dialog. Perhaps thee.preventDefault();
in thedata-confirm
handler could be changed to ignore all following event handlers instead of just the default event handler, but I didn't pursue this since I don't know if this would break another part of Weasyl.Closes #1462.