Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sanpera, Replace with Pillow #688

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

sl1-1
Copy link
Contributor

@sl1-1 sl1-1 commented Jan 9, 2020

Removes dependency on sanpera, replacing it's functions with pillow

@sl1-1
Copy link
Contributor Author

sl1-1 commented Jan 9, 2020

This is more a looking for feedback pull request, then a do it pull request :)

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #688 into master will decrease coverage by 0.15%.
The diff coverage is 85.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   68.74%   68.58%   -0.16%     
==========================================
  Files         157      157              
  Lines       12985    12725     -260     
==========================================
- Hits         8927     8728     -199     
+ Misses       4058     3997      -61
Impacted Files Coverage Δ
weasyl/commishinfo.py 63.84% <ø> (ø) ⬆️
weasyl/controllers/user.py 36.84% <ø> (+0.59%) ⬆️
weasyl/controllers/routes.py 100% <ø> (ø) ⬆️
weasyl/macro.py 77.77% <ø> (-1.82%) ⬇️
libweasyl/libweasyl/constants.py 100% <ø> (ø) ⬆️
weasyl/errorcode.py 100% <ø> (ø) ⬆️
weasyl/controllers/detail.py 50.58% <ø> (ø) ⬆️
libweasyl/libweasyl/exceptions.py 100% <ø> (ø) ⬆️
weasyl/controllers/profile.py 33.18% <ø> (+0.44%) ⬆️
weasyl/cron.py 0% <0%> (ø) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f240721...bec78db. Read the comment docs.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2020

This pull request fixes 2 alerts when merging aa42d5b into dd316fc - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unreachable code

@sl1-1 sl1-1 marked this pull request as ready for review January 26, 2020 21:10
@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2020

This pull request fixes 2 alerts when merging f240721 into 578961f - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Feb 23, 2020

This pull request fixes 2 alerts when merging 307bc68 into 123a690 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Feb 23, 2020

This pull request fixes 2 alerts when merging 75f5c24 into 123a690 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Feb 24, 2020

This pull request fixes 2 alerts when merging bec78db into 3163834 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unreachable code

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f277273). Click here to learn what that means.
The diff coverage is 84.01%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #688   +/-   ##
=========================================
  Coverage          ?   68.58%           
=========================================
  Files             ?      157           
  Lines             ?    12725           
  Branches          ?        0           
=========================================
  Hits              ?     8728           
  Misses            ?     3997           
  Partials          ?        0           
Impacted Files Coverage Δ
libweasyl/libweasyl/test/test_media.py 100.00% <ø> (ø)
libweasyl/libweasyl/models/media.py 84.55% <20.00%> (ø)
weasyl/avatar.py 28.57% <28.57%> (ø)
weasyl/media.py 55.55% <30.00%> (ø)
weasyl/thumbnail.py 43.58% <40.00%> (ø)
weasyl/submission.py 53.75% <66.66%> (ø)
weasyl/image.py 60.00% <69.23%> (ø)
libweasyl/libweasyl/images.py 86.11% <85.87%> (ø)
libweasyl/libweasyl/files.py 89.13% <100.00%> (ø)
libweasyl/libweasyl/test/test_images.py 100.00% <100.00%> (ø)
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f277273...2055434. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2020

This pull request fixes 2 alerts when merging 2c49055 into f277273 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2020

This pull request fixes 2 alerts when merging 2055434 into f277273 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unreachable code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants