Remove storify #744

sl1-1 · 2020-02-17T22:21:58Z

Removes the need for web_input_request_method

update tests to reflect changes to login.py and resetpassword.py

lgtm-com · 2020-02-17T23:24:03Z

This pull request introduces 3 alerts when merging e8c49f0 into 620f84c - view on LGTM.com

new alerts:

2 for Redundant assignment
1 for Unused import

codecov-io · 2020-02-17T23:45:40Z

Codecov Report

Merging #744 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files         156      156           
  Lines       12450    12450           
=======================================
  Hits         8403     8403           
  Misses       4047     4047

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222a53e...222a53e. Read the comment docs.

lgtm-com · 2020-02-28T20:28:49Z

This pull request introduces 1 alert when merging 4a949b9 into 3588638 - view on LGTM.com

new alerts:

1 for Syntax error

weasyl/controllers/general.py

weasyl/controllers/interaction.py

weasyl/controllers/moderation.py

weasyl/controllers/general.py

weasyl/controllers/api.py

weasyl/controllers/content.py

weasyl/controllers/moderation.py

weasyl/moderation.py

weasyl/report.py

weasyl/test/login/test_create.py

Co-Authored-By: Charmander <[email protected]>

charmander

There are some .get('name', False)s that should probably just be .get('name') (since they were originally the equivalent of .get('name', '')), but we can fix that later.

It might be safer to review, merge, and deploy this one piece at a time…

charmander · 2020-04-03T07:17:33Z

weasyl/controllers/api.py

-        if form.since:
-            since = d.parse_iso8601(form.since)
-        count = int(form.count)
+        if 'since' in request.params:


This will make an empty ?since= will stop working. I think we may as well keep full backwards compatibility here.

charmander · 2020-04-03T07:17:55Z

weasyl/controllers/api.py

    return submission.select_view_api(
        request.userid, int(request.matchdict['submitid']),
-        anyway=bool(form.anyway), increment_views=bool(form.increment_views))
+        anyway=('anyway' in request.params), increment_views=('increment_views' in request.params))


Behaviour difference for empty values ?anyway=, ?increment_views=.

Suggested change

anyway=('anyway' in request.params), increment_views=('increment_views' in request.params))

anyway=bool(request.params.get('anyway')), increment_views=bool(request.params.get('increment_views'))

charmander · 2020-04-07T04:03:17Z

weasyl/controllers/content.py


-    if 'customthumb' in form:
+    if request.params.get('customthumb', False):


Fully preserving the original behaviour (correct):

Suggested change

if request.params.get('customthumb', False):

if 'customthumb' in request.params:

charmander · 2020-04-08T07:20:43Z

weasyl/controllers/settings.py

+    sites = zip(site_names, site_values)
+
+    if 'more' in request.params:
+        form = request.params.mixed()


mixed adds a lot of potential type confusion. I think it’s best to create a dict explicitly instead.

sl1-1 added 17 commits February 17, 2020 13:41

remove use of storify in controllers/marketplace.py

8eb489c

remove dependency on storify for controllers/user.py

6323a1b

update tests to reflect changes to login.py and resetpassword.py

remove dependency on storify from controllers/general.py

f056fad

remove dependency on storify from controllers/settings.py

f888bcc

remove dependency on storify from controllers/profile.py

04436ea

remove dependency on storify from controllers/content.py

a11727f

remove dependency on storify from controllers/detail.py

e9a241d

remove storify from controllers/messages.py

c9e5d58

Remove dependency on storify from controllers/interaction.py

596c90d

remove dependency on storify from controllers/moderation.py

f0c512c

remove dependency on storify from controllers/admin.py

2c674ac

remove dependency on storify from controllers/director.py

daae586

remove dependency on storify from controllers/api.py

4e49905

remove dependency on storify from controllers/weasyl_collections.py

947fa78

remove storify dependency from oauth2.py

6ef7e51

remove web_input_request_method

0684f84

Merge branch 'master' into Remove_storify

e8c49f0

resolve issues detected by LGTM

5430fdf

Merge branch 'master' into Remove_storify

4a949b9

Fix merge issue

e62cb3e

charmander requested changes Mar 2, 2020

View reviewed changes

weasyl/controllers/general.py Outdated Show resolved Hide resolved

weasyl/controllers/interaction.py Outdated Show resolved Hide resolved

weasyl/controllers/moderation.py Outdated Show resolved Hide resolved

weasyl/controllers/general.py Outdated Show resolved Hide resolved

sl1-1 added 2 commits March 3, 2020 19:04

adjustments as recommended in code review

046d200

Fix test

795bc9b

charmander requested changes Mar 5, 2020

View reviewed changes

kfkitsune mentioned this pull request Mar 5, 2020

require_id/require_int/require_int_or_none #770

Open

sl1-1 and others added 2 commits March 7, 2020 13:53

Update weasyl/controllers/api.py

6e0eeb1

Co-Authored-By: Charmander <[email protected]>

Apply suggestions from code review

5a17484

Co-Authored-By: Charmander <[email protected]>

sl1-1 and others added 8 commits March 7, 2020 15:02

Cleanup

221f53e

Apply suggestions from code review

d81eb54

Co-Authored-By: Charmander <[email protected]>

More cleanup as recommended by code review

4c76cc6

Merge remote-tracking branch 'remotes/Weasyl/master' into Remove_storify

b0e5236

Merge branch 'master' into Remove_storify

7aaa41e

Merge branch 'master' into Remove_storify

2a599eb

Remove last use of weasyl.test.utils.Bag

de72c45

Merge branch 'master' into Remove_storify

222a53e

charmander requested changes Apr 8, 2020

View reviewed changes

charmander mentioned this pull request Apr 16, 2020

remove dependency on storify from controllers/admin.py #794

Merged

charmander mentioned this pull request Apr 26, 2020

remove dependency on storify from controllers/general.py #797

Closed

charmander force-pushed the master branch from c005258 to e64a38c Compare March 21, 2021 00:28

charmander force-pushed the master branch from 3a84f38 to fadd228 Compare July 18, 2021 02:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove storify #744

Remove storify #744

sl1-1 commented Feb 17, 2020

lgtm-com bot commented Feb 17, 2020

codecov-io commented Feb 17, 2020 •

edited

Loading

lgtm-com bot commented Feb 28, 2020

charmander left a comment

charmander Apr 3, 2020

charmander Apr 3, 2020

charmander Apr 7, 2020

charmander Apr 8, 2020

	anyway=('anyway' in request.params), increment_views=('increment_views' in request.params))
	anyway=bool(request.params.get('anyway')), increment_views=bool(request.params.get('increment_views'))


		if 'customthumb' in form:
		if request.params.get('customthumb', False):

	if request.params.get('customthumb', False):
	if 'customthumb' in request.params:

Remove storify #744

Are you sure you want to change the base?

Remove storify #744

Conversation

sl1-1 commented Feb 17, 2020

lgtm-com bot commented Feb 17, 2020

codecov-io commented Feb 17, 2020 • edited Loading

Codecov Report

lgtm-com bot commented Feb 28, 2020

charmander left a comment

Choose a reason for hiding this comment

charmander Apr 3, 2020

Choose a reason for hiding this comment

charmander Apr 3, 2020

Choose a reason for hiding this comment

charmander Apr 7, 2020

Choose a reason for hiding this comment

charmander Apr 8, 2020

Choose a reason for hiding this comment

codecov-io commented Feb 17, 2020 •

edited

Loading