Add email for signing up while awaiting verification #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds another template and calls it when the user attempts to sign up again with another username, sending another email with the verification link. Addresses issue #76
charmander
reviewed
Nov 5, 2020
| "email/email_in_use_account_creation.html", [query_username_login])) | ||
| else: | ||
| emailer.send(email, "Weasyl Account Creation - Account Already Exists", d.render( | ||
| "email/email_in_use_account_creation_in_progress.html", [token, query_username_logincreate])) |
There was a problem hiding this comment.
Thanks for the PR – this is a very important feature!
It looks like the token being sent here will correspond to the invalid logincreate record created on line 271. Do we need to look up the real one, or did you test it and find out that the one that was intended to be invalid accidentally works in this situation? :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another template and calls it when the user attempts to sign
up again with another username, sending another email with the
verification link.
Addresses issue #76
I'm having issues making the dev environment so I wasn't able to test this. I'm trying to fix that and posted a few messages on Gitter, but there wasn't much changed.