Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Add World Events #4

Closed
wants to merge 2 commits into from
Closed

Add World Events #4

wants to merge 2 commits into from

Conversation

TheBrokenRail
Copy link

Fixes #3

While this PR is based on the 1.15.2 branch, it used JavaDoc from Yarn 1.16.1.

FabricMC/yarn#1652

@TheBrokenRail
Copy link
Author

I have changed the Weft build process so it no longer converts from intermediary -> official, I did this originally for debugging, but I think it makes more sense anyways. Since it is guaranteed for the official mappings to change from 1.16.2-pre1 to 1.16.2-pre2 for instance, while the intermediary mapping will most likely stay the same. It also heavily simplifies the Weft build process. If you would like this change reverted I would be happy to, but IMO converting to official just doesn't make that much sense form what I know.

@Daomephsta
Copy link
Collaborator

Daomephsta commented Aug 6, 2020

Don't make multiple unrelated changes in one PR. Each unrelated change should be its own PR.
This applies to any project on any PR-supporting Git host.

With regards to the build process changes, I'm not interested in those. Weft is due to be merged with Yarn, and Warp with Loom.
That'll involve a large rewrite anyway, because the way Warp externally hooks into Loom is a bit of a hack.

@TheBrokenRail
Copy link
Author

Might as well close this until Weft is properly merged into Yarn.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants