Skip to content

fix issue of browserStorage to support multiple storeKey #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix issue of browserStorage to support multiple storeKey #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/openlogin-utils/src/browserStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ export class MemoryStore implements IStorage {
}

export class BrowserStorage {
// eslint-disable-next-line no-use-before-define
private static instance: BrowserStorage;
private static instanceMap = new Map<string, BrowserStorage>();

public storage: IStorage;

Expand All @@ -33,7 +32,7 @@ export class BrowserStorage {
}

static getInstance(key: string, storageKey: "session" | "local" = "local"): BrowserStorage {
if (!this.instance) {
if (!this.instanceMap.has(key)) {
let storage: IStorage;
if (storageKey === "local" && storageAvailable("localStorage")) {
storage = window.localStorage;
Expand All @@ -43,9 +42,9 @@ export class BrowserStorage {
storage = new MemoryStore();
}

this.instance = new this(key, storage);
this.instanceMap.set(key, new this(key, storage));
}
return this.instance;
return this.instanceMap.get(key);
}

toJSON(): string {
Expand Down