Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add passkey and Add authenticator #340

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Add passkey and Add authenticator #340

merged 2 commits into from
Sep 12, 2024

Conversation

arch1995
Copy link
Contributor

@arch1995 arch1995 commented Sep 12, 2024 •
edited
Loading

Motivation and Context

Allows account dashboard to add authenticator and passkeys as factor.

Jira Link: https://toruslabs.atlassian.net/browse/PD-3373

Description

  • Adds function to add authenticator and passkeys as MFA factor.

How has this been tested?

Developer tested this manually.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arch1995 arch1995 self-assigned this Sep 12, 2024
@arch1995 arch1995 changed the title enables addpasskey and addauthenticator addpasskey and addauthenticator Sep 12, 2024
@arch1995 arch1995 changed the title addpasskey and addauthenticator Add passkey and Add authenticator Sep 12, 2024
chaitanyapotti
chaitanyapotti approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 103f772 into master Sep 12, 2024
3 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/auth-dashboard branch September 12, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees

@arch1995 arch1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arch1995 @chaitanyapotti