Skip to content

seedless onboarding password sync #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 36 commits into
base: feat/seedless-multi-srp
Choose a base branch
from

Conversation

tuna1207
Copy link
Member

@tuna1207 tuna1207 commented Apr 25, 2025

Explanation

Handle password sync flow

  • Add checkIsPasswordOutdated method (which is cached for 15 mins)
  • Add password check to fetch all SRPs and change password
  • Add recover password method to recover old password using latest global password
  • Add sync latest global password to reset vault to use latest password and persist latest auth pubkey

References

https://docs.google.com/document/d/1r7WwVgrdmBLzhX7yYDrVc-NEs_Q02VPBGXi2-VGQAyc/edit?tab=t.0

Changelog

  • Add checkIsPasswordOutdated method
  • Add password check to fetch all SRPs and change password
  • Add recoverPassword method
  • Add syncLatestGlobalPassword method

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@tuna1207 tuna1207 changed the base branch from main to feat/seedless-onboarding-toprf April 25, 2025 01:43
@lwin-kyaw lwin-kyaw changed the base branch from feat/seedless-onboarding-toprf to feat/seedless-multi-srp April 25, 2025 02:21
@tuna1207 tuna1207 force-pushed the feat/seedless-onboarding-password-sync branch from e6e424b to 60cff9b Compare April 25, 2025 05:00
…d-sync' into feat/seedless-onboarding-password-sync
@lwin-kyaw
Copy link

lgtm.

Copy link
Member

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, minor comments

@tuna1207 tuna1207 force-pushed the feat/seedless-onboarding-password-sync branch from d7c3553 to 9cf2022 Compare May 14, 2025 14:51
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@matthiasgeihs
Copy link

@tuna1207 To satisfy the changelog checker, you need to add an entry to the CHANGELOG.md that references this PR.
See here, for example.

@lwin-kyaw lwin-kyaw marked this pull request as ready for review May 19, 2025 04:34
Copy link

@matthiasgeihs matthiasgeihs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go. Just need to add link to PR to make change log checker happy. See here.

@tuna1207 tuna1207 requested a review from matthiasgeihs May 21, 2025 11:40
Copy link

@matthiasgeihs matthiasgeihs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review comments have been addressed except for removing the .tgz file. i presume it needs to be there until a more recent version has been published? not sure if you wanna remove it before merging the PR into the feature branch, or only when the feature branch is ready.

@tuna1207 tuna1207 force-pushed the feat/seedless-onboarding-password-sync branch from 16a7712 to 235e255 Compare May 23, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants