Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly error on a return in a non-function scope #7256

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Properly error on a return in a non-function scope #7256

merged 1 commit into from
Jan 31, 2025

Conversation

kripken
Copy link
Member

@kripken kripken commented Jan 30, 2025

Without this we get an assertion later on,

child-typer.h:720:  Assertion `func' failed.

Returns use the function to find the return values, so like local
get and set, we must error early on lacking a function.

@kripken kripken requested a review from tlively January 30, 2025 23:03
@kripken kripken merged commit e629264 into WebAssembly:main Jan 31, 2025
14 checks passed
@kripken kripken deleted the parse.return.nofunc branch January 31, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @tlively