Skip to content

Fix Branch Hinting iostream printing #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

kripken
Copy link
Member

@kripken kripken commented May 16, 2025

The code saved and restored std::cout, not the current stream... and the
current stream is std::cout in most tests, so this went unnoticed. Printing
from wasm-dis works otherwise apparently, and the bug showed up there.

@kripken kripken requested a review from tlively May 16, 2025 15:52
@kripken kripken merged commit f27ff3e into WebAssembly:main May 16, 2025
14 checks passed
@kripken kripken deleted the bh.print.yikes branch May 16, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants