Skip to content

Directize: Refine results #7974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

Directize: Refine results #7974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
661a8fe
Directize: Refine results
kripken Oct 16, 2025
c696b94
format
kripken Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/passes/Directize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,15 @@ struct FunctionDirectizer : public WalkerPass<PostWalker<FunctionDirectizer>> {

// Everything looks good!
auto name = std::get<CallUtils::Known>(info).target;
replaceCurrent(
Builder(*getModule())
.makeCall(name, operands, original->type, original->isReturn));
auto results = getModule()->getFunction(name)->getResults();
replaceCurrent(Builder(*getModule())
.makeCall(name, operands, results, original->isReturn));

// When we call a function of a subtype of the call_indirect's call type, we
// may be refining results.
if (results != original->type) {
changedTypes = true;
}
}
};

Expand Down
37 changes: 37 additions & 0 deletions test/lit/passes/directize-gc.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,40 @@
)
)

;; call_indirect using the supertype. The direct call has a more refined type,
;; which we must update the IR to.
(module
(rec
;; CHECK: (rec
;; CHECK-NEXT: (type $super (sub (func (result (ref any)))))
(type $super (sub (func (result (ref any)))))
;; CHECK: (type $sub (sub $super (func (result (ref none)))))
(type $sub (sub $super (func (result (ref none)))))
)

;; CHECK: (table $table 42 funcref)
(table $table 42 funcref)
;; CHECK: (elem $elem (i32.const 0) $sub)
(elem $elem (i32.const 0) $sub)

;; CHECK: (func $super (type $super) (result (ref any))
;; CHECK-NEXT: (block $show-type (result (ref none))
;; CHECK-NEXT: (call $sub)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
(func $super (type $super) (result (ref any))
(block $show-type (result (ref any))
(call_indirect $table (type $super)
(i32.const 0)
)
)
)

;; CHECK: (func $sub (type $sub) (result (ref none))
;; CHECK-NEXT: (unreachable)
;; CHECK-NEXT: )
(func $sub (type $sub) (result (ref none))
(unreachable)
)
)

Loading