Change task.return to take component-level type + canonopt immediates #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewagner
commented
Dec 16, 2024
Comment on lines
+354
to
+358
| (core module $Libc | ||
| (memory (export "mem") 1) | ||
| (func (export "realloc") (param i32 i32 i32 i32) (result i32) ...) | ||
| ... | ||
| ) |
There was a problem hiding this comment.
FYI: This and most of the changes below in Async.md are pre-existing fixes that were made more evident when thinking about the <canonopt>* immediate of (canon task.return ...) below.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original async PR (#363), there seemed to be a reason to reuse the same core wasm type-equality test used by
call_indirectintask.returnto avoid a new kind of (component-level) type equality test. However, the streams PR (#405) ended up adding a well-motivated runtime component-type-equality test. Without that reason, passing the component-level return type +canonopts seems to be the more natural choice, so this PR switches to that.