Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stream.{read,write}s of length 0 to query/signal readiness #444

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow stream.{read,write}s of length 0 to query/signal readiness #444

wants to merge 1 commit into from

Conversation

lukewagner
Copy link
Member

This PR relaxes the rules for stream.{read,write} to accept lengths of 0. This can be useful for signalling and querying readiness which in turn can be used to implement non-blocking POSIX operations, as discussed in #441.

@lukewagner lukewagner mentioned this pull request Jan 29, 2025
Open
@lukewagner
Copy link
Member Author

Updated the PR based on further discussion in #441 about what happens when a 0-length read and write rendezvous. In the previous iteration, both were notified; with this update, only the writer is notified, since this ends up being what you want if there is going to be buffering (as mentioned in the PR and also this comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukewagner