Simplify CABI async code #553
Merged
+2,040
−1,952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewagner
force-pushed
the
refactor
branch
3 times, most recently
from
ad31115 to
7cf90d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just refactoring and shouldn't change the specified behavior. The PR reimplements how async works to be based on Python threads (
threading.Thread), using locks to emulate fibers and cooperative switching instead of the current approach of using Pythonasync/asyncio. This spun out of work to add cooperative threads, but it ended up being a significant simplification (kindof embarrassingly so) on its own, so I thought I'd spin it out into its own PR that could merge earlier.The PR also adds a new top-level "Embedding" section to
CanonicalABI.md(in the same spirit as core wasm's) that describes the top-level interaction between the embedder and wasm runtime which, with the asyncio impl, was rather ambiguous.I'll leave the PR open for a while in case anyone who's familiar with the current Python code wants to take a look, review or comment, but if not that's fine too.