Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] text format: drop support for some pre-standard keywords #1680

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

keithw
Copy link
Member

@keithw keithw commented Sep 20, 2023

In 2018 (#720 and #926), the spec renamed some keywords before WebAssembly was standardized (get_local -> local.get, anyfunc -> funcref, etc.).

WABT dropped support for the old names in 2021 (WebAssembly/wabt#1792), MDN revised its documentation in 2022 (mdn/interactive-examples#2298), and wasm-tools dropped support last month (bytecodealliance/wasm-tools#1184). However, users do get confused when they find a tutorial that uses the old syntax and the code works in more-tolerant implementations but is rejected by other conforming consumers. (E.g. WebAssembly/wabt#1802, WebAssembly/wabt#1820, WebAssembly/wabt#1883, WebAssembly/wabt#2010, ...)

Now that it's been five years and tutorials using the old syntax are increasingly rare, this PR would check that the old keywords are now considered malformed.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except nit: can we rename the test to obsolete-keywords?

@keithw
Copy link
Member Author

keithw commented Sep 20, 2023

LGTM, except nit: can we rename the test to obsolete-keywords?

Sure, pushed.

@rossberg rossberg merged commit cf73a6d into WebAssembly:main Sep 20, 2023
1 check passed
@keithw keithw deleted the renamed-keywords branch September 20, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants