[interpreter]: Add depends to dune-project #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossberg
reviewed
Jan 4, 2024
|
Thank you for your reply, I have removed the formatting related lines. |
|
I believe this is not correct and should be reverted. The interpreter ( People won't be happy about having to install some ppx trash for this package... One solution would be to mark them as development dependencies with e.g. |
|
Fair enough, I reverted the change. |
dhil
added a commit
to wasmfx/specfx
that referenced
this pull request
Jan 25, 2024
* [test] Adjust br_table length test to avoid wrong failure (WebAssembly#1715) * [spec] Fix extmul & extadd execution (WebAssembly#1716) * [interpreter] Add dune dependencies (WebAssembly#1717) * Revert "[interpreter] Add dune dependencies (WebAssembly#1717)" This reverts commit 44ed035. * [interpreter/test] Fix inconsistent use of float values in `spectest` (WebAssembly#1718) * [spec] Fix operand order in reduction of shape.replace_lane (WebAssembly#1721) * [spec] Fix sx to be sx? in reduction of vcvtop_zero (WebAssembly#1720) --------- Co-authored-by: Rod Vagg <[email protected]> Co-authored-by: 702fbtngus <[email protected]> Co-authored-by: Muqiu Han (韩暮秋) <[email protected]> Co-authored-by: Andreas Rossberg <[email protected]> Co-authored-by: Dongjun Youn / 윤동준 <[email protected]> Co-authored-by: Hoseong Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add depends to
dune-projectso that dependencies can be installed by callingopam install . --deps-only --with-doc --with-testand then build the interpreter from source :)