[test] Add tests checking that multiple sections aren't supported #1773
+114
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the start section had a test assuring its uniqueness. Cases in which there were two or more of the other sections weren't failing when implementing LibWasm for the Ladybird browser.
rossberg
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the start section had a test assuring its uniqueness. Cases in which there were two or more of the other sections weren't failing when implementing LibWasm for the Ladybird browser.
I'm not sure if these test cases are totally needed, but LibWasm's
Moduletype used to have an interesting way to represent sections, and these cases slipped through... so feel free to close this PR if it's deemed unnecessary.