Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add tests ensuring table type is grown in table.grow #1784

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

dzfrias
Copy link
Contributor

@dzfrias dzfrias commented Aug 18, 2024

No previous tests check that table.grow grows the table instance's type. This was found when implementing LibWasm for the Ladybird browser.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good to me, but this should go to table_grow.wast (imports are only used as a means for observing the table's runtime type).

@dzfrias
Copy link
Contributor Author

dzfrias commented Aug 18, 2024

A similar test for memory.grow is in imports.wast. Should I move both?

@rossberg
Copy link
Member

Ah, good point. Yeah, that is ancient, and worth moving as well.

@dzfrias
Copy link
Contributor Author

dzfrias commented Aug 22, 2024

Ok, I just moved them to their respective files. Thank you!

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@rossberg rossberg merged commit 71755b3 into WebAssembly:main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants