Fix CI from upgraded cmake version on GitHub Ubuntu runner #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Jul 30, 2023
|
I filed a PR to fix the underlying deprecation warning in libuv (libuv/libuv#4111); I think we can go back and remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub recently upgraded the cmake version on its Ubuntu runners, which broke our CI build with some new warnings (errors for us).
One of them is fixable (related to a deprecated Python package), but one of them is in libuv (which is a dependency of the uvwasi submodule) so less easy to fix. I added
-Wno-deprecatedto the cmake command line on GitHub actions to silence the warning for now.