wasm2c: ensure force read constraints compile for clang on mips #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithw
reviewed
Jul 30, 2023
shravanrn
force-pushed
the
wasm2c-force-read-mips
branch
from
db91146
to
f482040
Compare
Fixed 👍 |
keithw
approved these changes
Jul 30, 2023
sbc100
reviewed
Jul 30, 2023
Open to it, but my take is that this feels like overkill at the moment. I tested this approach on Godbolt to make sure it works. I think we can push this until/if we see other mips incompatibilities |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean slate attempt to fix #2266. To fix this i looked into how clang and gcc handle floating point constraints across a host of platforms.
Godbolt link: https://godbolt.org/z/ddeWc6ees
Results are in table below.
Given this, it seems the simplest course of action that maintains functionality as is today, but fix the mips platform is to special case this. We can separately file a bug upstream (but best case scenario is that will likely get fixed only for future clang versions, so I'm not sure we can rely on just that).
Fyi, @glandium
gcc
x86 - both
x86-64 - both
aarch32 - only "r"
aarch64 - only "r"
mips - only "r"
mips64 - both
riscv32 - both
riscv64 - both
sparc - both
sparc64 - both
powerpc - both
powerpc64 - both
clang
x86 - both
x64 - both
aarch32 - only "r"
aarch64 - only "r"
mips - only "f"
mips64 - only "f"
riscv32 - both
riscv64 - both
powerpc64 - both