-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the custom-page-sizes proposal #2502
Conversation
7e4c060
to
c28be4f
Compare
c28be4f
to
17904af
Compare
This adds support in the binary/text parsers and writers, the validator and interpreter, and objdump (but not wasm2c).
17904af
to
e2429a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! Love to see it! I'll add a link to this PR from the proposal's Overview.md
.
FWIW, if you want to hammer on this implementation a bit,
You can throw that in a loop, pass each test case to WABT, and see if you can find any bugs :) (There are also lots of other knobs you can configure to control Wasm module generation, for example you can disable random imports to make the modules self contained, turn off the GC proposal, etc...) |
This PR adds support for the custom-page-sizes proposal to the lexer, the binary/text parsers and writers, the validator, interpreter, and objdump.
Will plan to add wasm2c in a future PR.
(@fitzgen)