-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to resources. #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert `descriptor` and `directory-entry-stream` to resources, and update the dependencies to account for the changes in WebAssembly/wasi-io#46 and WebAssembly/wasi-clocks#50.
Closed
sunfishcode
added a commit
to sunfishcode/wasi-cli
that referenced
this pull request
Sep 13, 2023
Convert terminal-input and terminal-output to resources, and update the dependencies to account for: - WebAssembly/wasi-io#46 - WebAssembly/wasi-clocks#50 - WebAssembly/wasi-filesystem#132 - WebAssembly/wasi-random#34 - WebAssembly/wasi-sockets#61
pchickey
approved these changes
Sep 29, 2023
The wit-bindgen issue affecting CI is now fixed, and we now have at least some implementation experience with this, so let's land this and continue to iterate from here. |
sunfishcode
added a commit
to WebAssembly/wasi-cli
that referenced
this pull request
Sep 29, 2023
* Convert to resources. Convert terminal-input and terminal-output to resources, and update the dependencies to account for: - WebAssembly/wasi-io#46 - WebAssembly/wasi-clocks#50 - WebAssembly/wasi-filesystem#132 - WebAssembly/wasi-random#34 - WebAssembly/wasi-sockets#61 * Update to the latest filesystem/types.wit. * Update to wit-abi-up-to-date@v15 and wit-deps 0.3.3. * Update to the latest main branches of the upstream repos. * Update to the latest dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
descriptor
anddirectory-entry-stream
to resources, and update the dependencies to account for the changes in WebAssembly/wasi-io#46 and WebAssembly/wasi-clocks#50.