Update thread id validation returned by __wasi_thread_spawn
#435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamt
suggested changes
Sep 11, 2023
| * (`>= 0`) or an error code (`< 0`). As in the unmodified version, all | ||
| * (`<1, 0x1FFFFFFF>`) or an error code (`< 0`). Please note that `0` is | ||
| * reserved for compatibility reasons and must not be returned by the runtime | ||
| * (if that happens, EAGAIN is returned). As in the unmodified version, all |
There was a problem hiding this comment.
why EAGAIN?
an assertion is more appropriate.
There was a problem hiding this comment.
Yeah, it might be better to crash to force people to go fix the engine. But otherwise this makes sense to me!
There was a problem hiding this comment.
fair enough, updated.
loganek
force-pushed
the
loganek/update-tid-validation
branch
from
0103e28 to
d52365b
Compare
According to the documentation: https://github.com/WebAssembly/wasi-threads#design-choice-thread-ids, TID should be in the range <1, 0x1FFFFFFF>
loganek
force-pushed
the
loganek/update-tid-validation
branch
from
d52365b to
78e3f09
Compare
abrown
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation: https://github.com/WebAssembly/wasi-threads#design-choice-thread-ids, TID should be in the range <1, 0x1FFFFFFF>