Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different makefile variable for -D__wasilibc_use_wasip2 #499

Merged

Conversation

alexcrichton
Copy link
Collaborator

This switches from EXTRA_CFLAGS to CFLAGS so when EXTRA_CFLAGS is in the environment to specify -g, for example, it doesn't override p2-handling logic.

This switches from `EXTRA_CFLAGS` to `CFLAGS` so when `EXTRA_CFLAGS` is
in the environment to specify `-g`, for example, it doesn't override
p2-handling logic.
@alexcrichton
Copy link
Collaborator Author

r? @dicej

@alexcrichton alexcrichton merged commit 44c4b1e into WebAssembly:main May 21, 2024
8 checks passed
@alexcrichton alexcrichton deleted the fix-p2-with-extra-cflags branch May 21, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants