Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some wasi-threads tests #37

Closed
wants to merge 1 commit into from
Closed

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Dec 21, 2022

(venv) spacetanuki% TOYWASM=~/git/toywasm/b/toywasm python3 test-runner/wasi_test_runner.py -t tests/wat/testsuite -r ~/git/toywasm/test/wasi-testsuite-adapter.py
Test wasi_threads_exit_nonmain_wasi passed
Test wasi_threads_exit_main_busy passed
Test wasi_threads_exit_main_wasi passed
Test wasi_threads_exit_nonmain_busy passed
Test wasi_threads_spawn passed
Test wasi_threads_exit_main_block passed
Test wasi_threads_exit_nonmain_block passed

===== Test results =====
Runtime: toywasm v0.0
Suite: WASI wat tests
  Total: 7
  Passed:  7
  Failed:  0

Test suites: 1 passed, 0 total
Tests:       7 passed, 0 total
(venv) spacetanuki% 

@yamt
Copy link
Contributor Author

yamt commented Dec 21, 2022

i've written these while implementing wasi-threads in toywasm.
but nothing in these tests is toywasm-specific as far as i know.

```
(venv) spacetanuki% TOYWASM=~/git/toywasm/b/toywasm python3 test-runner/wasi_test_runner.py -t tests/wat/testsuite -r ~/git/toywasm/test/wasi-testsuite-adapter.py
Test wasi_threads_exit_nonmain_wasi passed
Test wasi_threads_exit_main_busy passed
Test wasi_threads_exit_main_wasi passed
Test wasi_threads_exit_nonmain_busy passed
Test wasi_threads_spawn passed
Test wasi_threads_exit_main_block passed
Test wasi_threads_exit_nonmain_block passed

===== Test results =====
Runtime: toywasm v0.0
Suite: WASI wat tests
  Total: 7
  Passed:  7
  Failed:  0

Test suites: 1 passed, 0 total
Tests:       7 passed, 0 total
(venv) spacetanuki%
```
@loganek
Copy link
Collaborator

loganek commented Dec 21, 2022

I'll review the tests in details after end of year holidays, but my initial thought was that this should for now live in https://github.com/WebAssembly/wasi-threads? In fact there's one basic test added there already: WebAssembly/wasi-threads#11

@yamt
Copy link
Contributor Author

yamt commented Dec 21, 2022

I'll review the tests in details after end of year holidays, but my initial thought was that this should for now live in https://github.com/WebAssembly/wasi-threads? In fact there's one basic test added there already: WebAssembly/wasi-threads#11

i haven't noticed that the "basic test" there was for the same test runner.
maybe i will move there.

@yamt
Copy link
Contributor Author

yamt commented Dec 22, 2022

moved to WebAssembly/wasi-threads#19

@yamt yamt closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants