Redis handler and heuristic calculator. #1345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s Handler now creates a generic structure with Redis data. Also Redis client is using redis-data no more. It now uses Lettuce with refflection
…s Handler now creates a generic structure with Redis data. Also Redis client is using redis-data no more. It now uses Lettuce with refflection
…om/WebFuzzing/EvoMaster into feature/redis-distance-calculation
jgaleotti
requested changes
Oct 22, 2025
...src/main/java/org/evomaster/client/java/controller/internal/db/RedisDistanceWithMetrics.java
Show resolved
Hide resolved
...r/src/main/java/org/evomaster/client/java/controller/internal/db/RedisCommandEvaluation.java
Show resolved
Hide resolved
| } | ||
|
|
||
| case HGETALL: { | ||
| List<RedisInfo> redisInfo = createRedisInfoForKeysByType("hash", redisClient); |
There was a problem hiding this comment.
replace "hash" with string constant
There was a problem hiding this comment.
Added constant Strings.
| } | ||
|
|
||
| case GET: { | ||
| List<RedisInfo> redisInfo = createRedisInfoForKeysByType("string", redisClient); |
There was a problem hiding this comment.
replace all "...." string constants with constant definitions
| } | ||
|
|
||
| default: | ||
| return new RedisDistanceWithMetrics(1d, 0); |
There was a problem hiding this comment.
replace 1d with constant value
There was a problem hiding this comment.
Added constant value for MAX_REDIS_DISTANCE in RedisHeuristicCalculator, and that is the value imported in RedisHandler.
|
|
||
| public class RedisHeuristicsCalculator { | ||
|
|
||
| public static final double MAX_DISTANCE = 1d; |
There was a problem hiding this comment.
rename to MAX_REDIS_DISTANCE
| * @param redisPattern the Redis glob-style pattern (e.g., "h?llo*", "user:[0-9]*") | ||
| * @return a valid Java regex string equivalent to the Redis pattern. | ||
| */ | ||
| private static String redisPatternToRegex(String redisPattern) { |
There was a problem hiding this comment.
move to a RedisUtils class, add test cases to check all cases are considered.
There was a problem hiding this comment.
Added RedisUtils and RedisUtilsTests
|
|
||
| import java.util.Set; | ||
|
|
||
| public class RedisInfo { |
There was a problem hiding this comment.
Add javadoc of this class, what is its purpose?
| // Parser rules have first letter in lower-case | ||
|
|
||
| pattern : disjunction; | ||
| pattern : disjunction EOF; |
There was a problem hiding this comment.
There have been changes to this file in master. Please pull changes and merge them.
There was a problem hiding this comment.
Merged master to this branch
| // Parser rules have first letter in lower-case | ||
|
|
||
| pattern : disjunction; | ||
| pattern : disjunction EOF; |
There was a problem hiding this comment.
Merged master to this branch
…s Handler now creates a generic structure with Redis data. Also Redis client is using redis-data no more. It now uses Lettuce with refflection
# Conflicts: # client-java/controller/src/main/java/org/evomaster/client/java/controller/internal/db/RedisHandler.java # client-java/controller/src/main/java/org/evomaster/client/java/controller/redis/RedisClient.java # client-java/controller/src/main/java/org/evomaster/client/java/controller/redis/RedisHeuristicsCalculator.java # client-java/controller/src/test/java/org/evomaster/client/java/controller/internal/db/redis/RedisHandlerIntegrationTest.java # client-java/controller/src/test/java/org/evomaster/client/java/controller/internal/db/redis/RedisHeuristicsCalculatorTest.java
…s Handler now creates a generic structure with Redis data. Also Redis client is using redis-data no more. It now uses Lettuce with refflection
…om/WebFuzzing/EvoMaster into feature/redis-distance-calculation
…s Handler now creates a generic structure with Redis data. Also Redis client is using redis-data no more. It now uses Lettuce with refflection
# Conflicts: # client-java/controller/src/main/java/org/evomaster/client/java/controller/internal/db/RedisHandler.java # client-java/controller/src/main/java/org/evomaster/client/java/controller/redis/RedisClient.java # client-java/controller/src/main/java/org/evomaster/client/java/controller/redis/RedisHeuristicsCalculator.java # client-java/controller/src/test/java/org/evomaster/client/java/controller/internal/db/redis/RedisHandlerIntegrationTest.java # client-java/controller/src/test/java/org/evomaster/client/java/controller/internal/db/redis/RedisHeuristicsCalculatorTest.java
…s Handler now creates a generic structure with Redis data. Also Redis client is using redis-data no more. It now uses Lettuce with refflection
# Conflicts: # client-java/controller/src/main/java/org/evomaster/client/java/controller/internal/db/RedisHandler.java # client-java/controller/src/main/java/org/evomaster/client/java/controller/redis/RedisClient.java # client-java/controller/src/main/java/org/evomaster/client/java/controller/redis/RedisHeuristicsCalculator.java # client-java/controller/src/test/java/org/evomaster/client/java/controller/internal/db/redis/RedisHandlerIntegrationTest.java # client-java/controller/src/test/java/org/evomaster/client/java/controller/internal/db/redis/RedisHeuristicsCalculatorTest.java
…s Handler now creates a generic structure with Redis data. Also Redis client is using redis-data no more. It now uses Lettuce with refflection
…s Handler now creates a generic structure with Redis data. Also Redis client is using redis-data no more. It now uses Lettuce with refflection
…om/WebFuzzing/EvoMaster into feature/redis-distance-calculation
jgaleotti
approved these changes
Oct 28, 2025
arcuri82
requested changes
Oct 30, 2025
| @@ -0,0 +1,16 @@ | |||
| package org.evomaster.client.java.controller.internal.db; | |||
There was a problem hiding this comment.
as more files are added to internal/db, should refactor, and have subfolders for internal/db/redis, internal/db/mongo and internal/db/opensearch
| * This class will link a given RedisCommand to the result of the distance calculation for that commmand. | ||
| */ | ||
| public class RedisCommandEvaluation { | ||
| public final RedisCommand redisCommand; |
There was a problem hiding this comment.
those should be private, with public getters. usually, we have public fields only for DTOs
| */ | ||
| public class RedisDistanceWithMetrics { | ||
| public final double redisDistance; // A number between 0 and 1. | ||
| public final int numberOfEvaluatedKeys; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added distance calculation for several Redis Commands.
RedisCommand class holds an attribute for each one that should have an heuristic value computation.