-
Notifications
You must be signed in to change notification settings - Fork 16
Conditionally show more metric details #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Now also updated the console output to include durations:
|
return `${time.toFixed(2)} ms`; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: double newline
} | ||
|
||
function shellFriendlyScore(time) { | ||
return `${uiFriendlyScore(time)} # `.padStart(valuePadding); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: not so sure about #
as the unit, it's not exactly self-explanatory and hard to grep/google. Maybe just spell out score
or points
?
This is the view you'll get after pressing

d
or clicking on the score: