-
Notifications
You must be signed in to change notification settings - Fork 16
Add npm run test:build script #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add npm run test:build script #189
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits/minor questions.
} | ||
} | ||
|
||
setImmediate(runBuilds); No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add newline
echo "Running in $BROWSER" | ||
npm run test:${{ matrix.browser }} | ||
- name: Run Build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordering question: is there a particular reason to have this after the Run Tests
step? Logically it seems to make sense to have build before test, so that we always run the freshly rebuilt workloads, right?
await sh("npm", "run", "build"); | ||
} finally { | ||
process.chdir(oldCWD); | ||
// await sh("git", "reset", "--hard"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove or add a comment maybe? Otherwise it looks like it's potentially forgotten/accidentally committed code.
With the newer workloads we should also check that the build steps keep on working in isolation.