Add npm run test:build script #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danleh
approved these changes
Oct 15, 2025
| } | ||
| } | ||
|
|
||
| setImmediate(runBuilds); No newline at end of file |
| echo "Running in $BROWSER" | ||
| npm run test:${{ matrix.browser }} | ||
| - name: Run Build |
There was a problem hiding this comment.
Ordering question: is there a particular reason to have this after the Run Tests step? Logically it seems to make sense to have build before test, so that we always run the freshly rebuilt workloads, right?
| await sh("npm", "run", "build"); | ||
| } finally { | ||
| process.chdir(oldCWD); | ||
| // await sh("git", "reset", "--hard"); |
There was a problem hiding this comment.
nit: remove or add a comment maybe? Otherwise it looks like it's potentially forgotten/accidentally committed code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the newer workloads we should also check that the build steps keep on working in isolation.