Skip to content

Conversation

camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Sep 22, 2025

With the newer workloads we should also check that the build steps keep on working in isolation.

  • Add "npm run test:build"
  • Include "test:build" in github actions
  • Fix web-ssr workload building by adding missing unicode-escape-webpack-plugin

Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit a18962c
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68d14e954f9d7800084da5ee
😎 Deploy Preview https://deploy-preview-189--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits/minor questions.

}
}

setImmediate(runBuilds); No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add newline

echo "Running in $BROWSER"
npm run test:${{ matrix.browser }}
- name: Run Build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordering question: is there a particular reason to have this after the Run Tests step? Logically it seems to make sense to have build before test, so that we always run the freshly rebuilt workloads, right?

await sh("npm", "run", "build");
} finally {
process.chdir(oldCWD);
// await sh("git", "reset", "--hard");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove or add a comment maybe? Otherwise it looks like it's potentially forgotten/accidentally committed code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants