-
Notifications
You must be signed in to change notification settings - Fork 16
Improve tags #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve tags #206
Conversation
camillobruni
commented
Oct 16, 2025
- Add stricter tests: tags cannot be benchmark names to avoid accidental selection
- Each benchmark needs to have at least one of "js" or "Wasm" tags
- "Deafult" tag is now lower-case
- Add "bigint" to bigint tests
- Rename "regexp" to "regexp-octane" to avoid clash with the tag of the same name
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit.
@kmiller68 are you ok with renaming "regexp" to "regexp-octane"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too.
There are few more suffixed examples thus stuck with |