StartupBenchmark should create sources lazily #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now StartupBenchmark builds all the sources it will need up front. This adds somewhat substantial memory overhead, in particular for jsdom-d3-startup where it seems to add about 50MB of overhead. This patch changes it so the source is generated in the prepareForNextIteration hook on demand before the next iteration starts.
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now StartupBenchmark builds all the sources it will need up front. This adds somewhat substantial memory overhead, in particular for jsdom-d3-startup where it seems to add about 50MB of overhead.
This patch changes it so the source is generated in the prepareForNextIteration hook on demand before the next iteration starts.
I also got rid of the unused zero sourceCodeReuseCount behavior where it didn't change the source code. It made the code more complex and seems like you wouldn't use StartupBenchmark in that case anyway.