Add three.js benchmark #75
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| const canvas = {} | ||
| canvas.addEventListener = function() { } | ||
| canvas.style = {} | ||
| canvas.getContext = function(kind) { |
There was a problem hiding this comment.
nit: I'd probably define the mock-canvas as object literal:
const canvas = {
addEventListener() {},
...
}
| for(let i = 0; i < NUM_PARTICLES; i++) { | ||
| const size = 10 + Math.random() * 80; | ||
| const particle = | ||
| createGeometryParticle(size); |
There was a problem hiding this comment.
nit: superfluous newline
|
|
||
| // Initialize particles | ||
| const particles = []; | ||
| for(let i = 0; i < NUM_PARTICLES; i++) { |
There was a problem hiding this comment.
Could we put this in the init() method?
This might be nice in the future for getting some extra coverage if we add timers.
There was a problem hiding this comment.
I also wouldn't be opposed to having this be part of the first iteration since this seems like the setup a real three.js app would do.
|
Generally LGTM. Would it make sense to bump to the latest threejs version as well? |
|
|
||
| // Initialize particles | ||
| const particles = []; | ||
| for(let i = 0; i < NUM_PARTICLES; i++) { |
There was a problem hiding this comment.
I also wouldn't be opposed to having this be part of the first iteration since this seems like the setup a real three.js app would do.
No description provided.