Make the github action linter step fail in the case of issues (#374)

* Make the github action linter step fail in the case of issues * Run the formatter on the project
WebKit · Feb 17, 2024 · ca9d23c · ca9d23c
1 parent 3d78224
commit ca9d23c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -26,6 +26,17 @@ jobs:
             - name: Run linters
               run: |
                   npm run format
+            - name: Check if anything changed
+              run: |
+                  git_status="`LC_ALL=C git status --porcelain --ignore-submodules -unormal 2>&1`"
+                  if [ -n "$git_status" ]; then
+                      printf "Some file(s) changed as the result of formatting, this means that you need to run the formatter on your patch.\n"
+                      printf "Here is what changed:\n"
+                      printf -- "$git_status\n\n"
+                      printf "And here is the diff:\n"
+                      git diff -U8
+                      exit 1
+                  fi
     build:
         name: Build
         runs-on: macos-latest

diff --git a/about.html b/about.html
@@ -18,7 +18,10 @@
                     <h1 class="section-header">About Speedometer 3</h1>
                     <div class="section-content">
                         <p>Speedometer 3 is a benchmark for web browsers that measures Web application responsiveness by timing simulated user interactions on various workloads.</p>
-                        <p>It's developed as an open source project, with decisions being made under a <a href="https://github.com/WebKit/Speedometer/blob/main/Governance.md">multistakeholder governance model</a> between the three widely distributed web browser engine projects.
+                        <p>
+                            It's developed as an open source project, with decisions being made under a <a href="https://github.com/WebKit/Speedometer/blob/main/Governance.md">multistakeholder governance model</a> between the three widely distributed
+                            web browser engine projects.
+                        </p>
                         <p>
                             The following high level user journeys are implemented in the current version. Each of these journeys has one or more workloads which test important aspects of it - for example commonly used patterns, frameworks, or
                             technologies.

diff --git a/resources/todomvc/architecture-examples/angular/angular.json b/resources/todomvc/architecture-examples/angular/angular.json
@@ -94,6 +94,6 @@
         }
     },
     "cli": {
-      "analytics": false
+        "analytics": false
     }
 }