Skip to content

Remove mockup storage and inline styles from web componenets todoMVC #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lpardosixtosMs
Copy link
Contributor

@lpardosixtosMs lpardosixtosMs commented Jul 15, 2025

The 2 main changes:

  1. Remove the lists of todo entries at the app and list level and keep them only as children of the todolist element.
  2. Remove inline styling of elements display, use css attribute selectors instead.

Results:

Label macos.arm64.local_0 macos.arm64.local_1 macos.arm64.local_2 macos.arm64.local_3
browser Google Chrome Microsoft Edge Firefox Safari
version 138.0.7204.158 138.0.3351.95 138.0.4 18.5.0.0.20621.2.5.11.8
os macos 15.5 arm64 macos 15.5 arm64 macos 15.5 arm64 macos 15.5 arm64
device MacBookPro17,1 MacBookPro17,1 MacBookPro17,1 MacBookPro17,1
cpu Apple M1 8 cores Apple M1 8 cores Apple M1 8 cores Apple M1 8 cores
runs 1 1 1 1
failed runs 0 0 0 0
TodoMVC-WebComponents 11.156666665772597 11.82666666706403 16.333333333333332 20.833333333333517
TodoMVC-WebComponents-Old 13.643333332240582 14.316666669150193 17.9 23.000000000000167
TodoMVC-WebComponents-Complex-DOM 14.856666666269302 14.879999998708566 21.833333333333332 26.400000000000258
TodoMVC-WebComponents-Old-Complex-DOM 18.479999998708568 17.890000000596046 25.033333333333335 27.766666666666666
Score 70.2810070365844 68.97575003170705 50.516728603241944 41.278491693043556

Comparison of sync and async steps:

image

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for webkit-speedometer-preview ready!

Name Link
🔨 Latest commit 2c1d75b
🔍 Latest deploy log https://app.netlify.com/projects/webkit-speedometer-preview/deploys/687998cc22ceb500086d336e
😎 Deploy Preview https://deploy-preview-521--webkit-speedometer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant