-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate command for all agents #272
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 93.06% 93.10% +0.04%
==========================================
Files 36 36
Lines 7121 7221 +100
==========================================
+ Hits 6627 6723 +96
- Misses 494 498 +4 ☔ View full report in Codecov by Sentry. |
Looks good to me @iFergal. I suppose this is more of an administrative feature, hence the command line tool. Do you have any thoughts how we can test a command like this in case migrate changes? |
Also @iFergal could you post a screenshot(s) showing the command being successfully used on this PR? |
Thanks @2byrds I added a screenshot and note to the description. Yeah based on recommendations from Phil, migrations should be manual, hence the cli. Regarding testing - I think we would need a minimal agent and set the migration version to the lowest, run On the other hand it's probably unlikely that the |
Based on discussions yesterday and WebOfTrust/keripy#824 more thought should be put into this. If SignifyGroupHab and other files move to KERIA, we may need a separate set of migrations for KERIA on top of calling |
This PR adds a
keria migrate
command that will fetch all of the agents from the agency DB and kick off the migrate doer used inkli migrate
. Slightly weird to mimic a kli command from keria but it works, and means we will pick up changes tokli migrate
.I also pinned the keripy version again - this got unpinned by mistake it seems. But as mentioned before we need it for determinism of builds.
Here is a screenshot example of incepting 2-of-2 multi-sig on an old version, trying to connect without migrating and successfully migrating:
Note:
SignifyGroupHabs
are not correctly migrated on keripy - but this is separate for now and has been raised in #257 - I gave some details on why in that issue yesterday.