exn Message Upgrades. #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exn messages. Add sender, recipient and embeds to exn messages to support attaching signed event messages that don't get processed automatically.
…embedded events with persistent exn messages. Support for loading and verify persisted exn messages.
…ial/issue exn message with transposed signatures instead of streamed over. There is also now a `kli vc accept` command to allow the issuee of a credential to accept or reject an issue credential.
Am I missing something. Because the credential issuance is anchored in a KEL which is signed, the credential itself does not need to be signed agains and signature attached, so there is no need for the transposed signatures of the embedded credential in this case? |
|
You are not missing anything, we have not removed the signatures from the credential, that is still an open issue. I didn't want to tackle that issue with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
exnmessages with full Seal to allow for long living exn messages. Add sender, recipient and embeds to exn messages to support attaching signed event messages that don't get processed automatically.kli vc acceptcommand to allow the issuee of a credential to accept or reject an issue credential.