fix: re-cue unmatched cues in Respondant #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeairheller
approved these changes
Jun 5, 2024
kentbull
pushed a commit
to kentbull/keripy
that referenced
this pull request
Jul 8, 2024
kentbull
pushed a commit
to kentbull/keripy
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve WebOfTrust/keria#184.
In KERIA, the Respondant processes certain cues for a kevery, but it drops other cues like
keyStateSavedand Phil has suggested this to be the safest change to make to resolve the issue.Since we are pushing the cue back onto the Deck, I needed to process one item per tock instead of looping the entire Deck and then yielding. An alternative is to keep another list of items and re-add them all after
while self.cuesis finished but I find this risky in case there are a lot of items and the process dies half way through.