Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow local tever events when not in local mode #806

Closed
wants to merge 1 commit into from
Closed

Allow local tever events when not in local mode #806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/keri/vdr/eventing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,8 +1559,7 @@ def processEvent(self, serder, seqner=None, saider=None, wigers=None):
"".format(regk, self.registries))
else:
if regk in self.registries: # local event when not in local mode
raise ValueError("Local event regk={} when nonlocal mode."
"".format(regk))
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the proper fix for this as it disables the features provided by both the lax and the local properties of the Tevery. Please use those flags when launching the Tevery to accomplish this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, the problem is that in KERIA we have one global Tevery process that is shared and used in the escrows. It's instantiated as non local. Do we need to check if the event is local or non local before launching a Tevery? I'll take a look on how that can be implemented in KERIA if that's the way to go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you can create 2 Tevery objects. One to use for local events that you create and one for remote messages that is used to process incoming messages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I'll look into that direction. The main problem to solve is that the incoming message received is the one that has the local event. We need to detect that before deciding which Tevery object should be called.


if regk not in self.tevers: # first seen for this registry
if ilk in [Ilks.vcp]:
Expand Down
Loading