Add filters and reverse ordering in Noter and Notifier #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeairheller
requested changes
Jul 11, 2024
| @@ -581,6 +581,37 @@ def getAllItemIter(self, db, key=b'', split=True, sep=b'.'): | |||
| splits = (bytes(key), val) | |||
| yield tuple(splits) | |||
|
|
|||
| def getAllItemRvsdIter(self, db, key=b'', split=True, sep=b'.'): | |||
There was a problem hiding this comment.
We already have a method that implements something similar to this and is called getIoValsAllPreBackIter. This name should match.
| @@ -353,7 +367,49 @@ def getNotes(self, start=0, end=25): | |||
| break | |||
|
|
|||
| return notes | |||
|
|
|||
| def getFltNotes(self, start=0, end=25, rvsd=False, read=None, route=None): | |||
There was a problem hiding this comment.
I don't think this is an appropriate approach for filtering messages in LMDB. It requires deserializing the data and analyzing it and it hard codes the fields you can search for.
If you look at the Seeker class in KERIA you'll see an approach to creating LMDB indexes that are more flexible and more performant than this approach.
|
Can this PR be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address a feature requested in KERIA (WebOfTrust/keria#266) to allow notifications to be ordered in reverse, and be filtered by the
readstatus and therouteparameter in theattrs(note.a.r) if exists.To get the notes in reversed order I added a new function in
LMDBercalledgetAllItemRvsdIterthat returns the reversed iterator.