-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tel state noticer to query for tel updates #868
Draft
iFergal
wants to merge
2
commits into
WebOfTrust:main
Choose a base branch
from
cardano-foundation:feat/telQuerier
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1644,14 +1644,15 @@ def processQuery(self, serder, source=None, sigers=None, cigars=None): | |
self.cues.append(dict(kin="replay", src=src, dest=source.qb64, msgs=msgs)) | ||
elif route == "tsn": | ||
ri = qry["ri"] | ||
src = qry["src"] | ||
if ri in self.tevers: | ||
tever = self.tevers[ri] | ||
tsn = tever.state() | ||
self.cues.push(dict(kin="reply", route="/tsn/registry", data=asdict(tsn), dest=source)) | ||
self.cues.push(dict(kin="reply", route=f"/tsn/registry/{src}", data=asdict(tsn), dest=source.qb64)) | ||
|
||
if vcpre := qry["i"]: | ||
tsn = tever.vcState(vcpre=vcpre) | ||
self.cues.push(dict(kin="reply", route="/tsn/credential", data=asdict(tsn), dest=source)) | ||
tsn = tever.vcState(vci=vcpre) | ||
self.cues.push(dict(kin="reply", route=f"/tsn/credential/{src}", data=asdict(tsn), dest=source.qb64)) | ||
|
||
else: | ||
raise ValidationError("invalid query message {} for evt = {}".format(ilk, ked)) | ||
|
@@ -1784,24 +1785,17 @@ def processReplyRegistryTxnState(self, *, serder, saider, route, cigars=None, ts | |
|
||
ldig = self.reger.getTel(key=snKey(pre=regk, sn=sn)) # retrieve dig of last event at sn. | ||
|
||
# Only accept key state if for last seen version of event at sn | ||
if ldig is None: # escrow because event does not yet exist in database | ||
if self.reger.txnsb.escrowStateNotice(typ="registry-ooo", pre=regk, aid=aid, serder=serder, saider=saider, | ||
dater=dater, cigars=cigars, tsgs=tsgs): | ||
self.cues.append(dict(kin="telquery", q=dict(ri=regk))) | ||
|
||
raise kering.OutOfOrderTxnStateError("Out of order txn state={}.".format(rsr)) | ||
|
||
tsaider = coring.Saider(qb64=rsr.d) | ||
ldig = bytes(ldig) | ||
# retrieve last event itself of signer given sdig | ||
sraw = self.reger.getTvt(key=dgKey(pre=regk, dig=ldig)) | ||
# assumes db ensures that sraw must not be none because sdig was in KE | ||
sserder = serdering.SerderKERI(raw=bytes(sraw)) | ||
if ldig is not None: # escrow because event does not yet exist in database | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. aligning with ksn |
||
ldig = bytes(ldig) | ||
# retrieve last event itself of signer given sdig | ||
sraw = self.reger.getTvt(key=dgKey(pre=regk, dig=ldig)) | ||
# assumes db ensures that sraw must not be none because sdig was in KE | ||
sserder = serdering.SerderKERI(raw=bytes(sraw)) | ||
|
||
if sserder.said != tsaider.qb64: # mismatch events problem with replay | ||
raise ValidationError("Mismatch keystate at sn = {} with db." | ||
"".format(rsr.s)) | ||
if sserder.said != tsaider.qb64: # mismatch events problem with replay | ||
raise ValidationError("Mismatch keystate at sn = {} with db." | ||
"".format(rsr.s)) | ||
|
||
self.reger.txnsb.updateReply(aid=aid, serder=serder, saider=tsaider, dater=dater) | ||
self.cues.append(dict(kin="txnStateSaved", record=rsr)) | ||
|
@@ -1924,28 +1918,21 @@ def processReplyCredentialTxnState(self, *, serder, saider, route, cigars=None, | |
|
||
ldig = self.reger.getTel(key=snKey(pre=vci, sn=sn)) # retrieve dig of last event at sn. | ||
|
||
# Only accept key state if for last seen version of event at sn | ||
if ldig is None: # escrow because event does not yet exist in database | ||
if self.reger.txnsb.escrowStateNotice(typ="credential-ooo", pre=vci, aid=aid, serder=serder, | ||
saider=saider, dater=dater, cigars=cigars, tsgs=tsgs): | ||
self.cues.append(dict(kin="telquery", q=dict(ri=regk, i=vci))) | ||
|
||
raise kering.OutOfOrderTxnStateError("Out of order txn state={}.".format(vsr)) | ||
|
||
tsaider = coring.Saider(qb64=vsr.d) | ||
ldig = bytes(ldig) | ||
# retrieve last event itself of signer given sdig | ||
sraw = self.reger.getTvt(key=dgKey(pre=vci, dig=ldig)) | ||
# assumes db ensures that sraw must not be none because sdig was in KE | ||
sserder = serdering.SerderKERI(raw=bytes(sraw)) | ||
if ldig is not None: | ||
ldig = bytes(ldig) | ||
# retrieve last event itself of signer given sdig | ||
sraw = self.reger.getTvt(key=dgKey(pre=vci, dig=ldig)) | ||
# assumes db ensures that sraw must not be none because sdig was in KE | ||
sserder = serdering.SerderKERI(raw=bytes(sraw)) | ||
|
||
if sn < sserder.sn: | ||
raise ValidationError("Stale txn state at sn = {} with db." | ||
"".format(vsr.s)) | ||
if sn < sserder.sn: | ||
raise ValidationError("Stale txn state at sn = {} with db." | ||
"".format(vsr.s)) | ||
|
||
if sserder.said != tsaider.qb64: # mismatch events problem with replay | ||
raise ValidationError("Mismatch txn state at sn = {} with db." | ||
"".format(vsr.s)) | ||
if sserder.said != tsaider.qb64: # mismatch events problem with replay | ||
raise ValidationError("Mismatch txn state at sn = {} with db." | ||
"".format(vsr.s)) | ||
|
||
self.reger.txnsb.updateReply(aid=aid, serder=serder, saider=tsaider, dater=dater) | ||
self.cues.append(dict(kin="txnStateSaved", record=vsr)) | ||
|
@@ -2007,12 +1994,8 @@ def processEscrows(self): | |
extype=kering.MissingRegistryError) | ||
self.reger.txnsb.processEscrowState(typ="credential-mae", processReply=self.processReplyCredentialTxnState, | ||
extype=kering.MissingAnchorError) | ||
self.reger.txnsb.processEscrowState(typ="credential-ooo", processReply=self.processReplyCredentialTxnState, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this change is right, maybe we should also remove the |
||
extype=kering.OutOfOrderTxnStateError) | ||
self.reger.txnsb.processEscrowState(typ="registry-mae", processReply=self.processReplyRegistryTxnState, | ||
extype=kering.MissingAnchorError) | ||
self.reger.txnsb.processEscrowState(typ="registry-ooo", processReply=self.processReplyRegistryTxnState, | ||
extype=kering.OutOfOrderTxnStateError) | ||
|
||
except Exception as ex: # log diagnostics errors etc | ||
if logger.isEnabledFor(logging.DEBUG): | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious if we should just skip this if
vci
is set below, depends on if we need to escrow or not