Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrations for 0.6.7 to 1.2.0 #875

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

kentbull
Copy link
Contributor

@kentbull kentbull commented Oct 8, 2024

Add database migrations for:

  • 0.6.7 (Jun 16, 2022) -> 0.6.8 (Nov 2, 2022): hab_data_rename (new)
  • 0.6.8 (Nov 2, 2022) -> 1.0.0 (Mar 31, 2023): add_key_and_reg_state_schemas (new)
  • 1.0.0 (Mar 31, 2023) -> 1.2.0 (Oct 4, 2024): rekey_habs (already existed)

I discovered the need for the hab_data_rename migration while testing migration for 0.6.7 test Root GAR databases similar to production as we believe v0.6.7 is what is in production for Root GARs.

The add_key_and_reg_state_schemas we initially thought was specific to Provenant yet in my testing it turns out it is needed to take a Root GAR 0.6.7 database up to 1.0.0, so not specific to Provenant.

I added the name, base, and temp args to db.migrate(...) so that the viring.Reger database could be initialized without having to open up the Habery.

@kentbull kentbull force-pushed the add-migrations-for-0_6_8-and-1_0_0 branch 2 times, most recently from b50993d to 8dd9403 Compare October 9, 2024 15:26
@kentbull kentbull force-pushed the add-migrations-for-0_6_8-and-1_0_0 branch from 8dd9403 to 539647a Compare October 9, 2024 18:26
@kentbull
Copy link
Contributor Author

kentbull commented Oct 9, 2024

This includes the semver cleanup idea from #872

@kentbull kentbull added the enhancement New feature or request label Oct 9, 2024
@kentbull kentbull self-assigned this Oct 9, 2024
Copy link
Member

@pfeairheller pfeairheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one change to remove the unneeded parameters and we should be good to merge.

src/keri/db/basing.py Outdated Show resolved Hide resolved
@pfeairheller pfeairheller merged commit e3d0ff5 into v1.2.0-rc3 Oct 10, 2024
6 checks passed
@pfeairheller pfeairheller deleted the add-migrations-for-0_6_8-and-1_0_0 branch October 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants