Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Compatibility #938

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

arilieb
Copy link
Contributor

@arilieb arilieb commented Feb 27, 2025

This PR is dependent on ioflo/hio#50. Though this PR should not effect MacOS functionality, it is intended to be merged after ioflo/hio#50.

  • Changed pathing to be OS agnostic
  • Implemented conditional hosts:
  • 0.0.0.0 on MacOS and Linux
  • 127.0.0.1 on Windows
  • Binding to 0.0.0.0 is designed to listen on all interfaces, including 127.0.0.1, but stricter firewall settings on Windows can sometimes filter local loopback traffic when accessed via 0.0.0.0. In these cases, explicitly using 127.0.0.1 ensures that local connections are reliably routed without interference from system-wide network policies.
  • Corrected streamCESRRequests URL pathing to use urllib instead of pathlib
  • Changed doify method to proper doing.Doer in test_indirecting.py :: test_wit_query_ends
  • Added 1 millisecond sleep to tests which could fail on higher speed CPUs due to multiple objects receiving the same datetime:
  • test_notifying.py :: test_dictersuber
  • test_helping.py :: test_iso8601
  • Implemented conditional checks for number of logger handlers to account for windows incompatibility with hio sys logging
  • Changed basing.py clean() method to adhere to stricter Windows policy disallowing moving files while they are still open

Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a great improvement to the library.

@m00sey
Copy link
Member

m00sey commented Feb 27, 2025

added do not merge label to coordinate on hio PR

@kentbull
Copy link
Contributor

Nice work, @arilieb. This is much needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants