Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use cesrnumber when parsing sn in rotate event #257

Merged
merged 2 commits into from
May 9, 2024

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented May 2, 2024

So it does the same as the "interact" function. See

const sner = new CesrNumber({}, sn);
if (sner.num < 1) {
throw new Error(`Invalid sn = 0x${sner.numh} for ixn.`);
}

Closes #220

Also related #138

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.76%. Comparing base (651bad6) to head (404c377).

❗ Current head 404c377 differs from pull request most recent head 97e071e. Consider uploading reports for the commit 97e071e to get more accurate results

Files Patch % Lines
src/keri/core/eventing.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files          46       46           
  Lines        4218     4218           
  Branches     1053     1029   -24     
=======================================
  Hits         3491     3491           
- Misses        698      722   +24     
+ Partials       29        5   -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan lenkan closed this May 5, 2024
@lenkan lenkan deleted the fix-number-constructor branch May 5, 2024 09:55
@lenkan lenkan restored the fix-number-constructor branch May 5, 2024 10:29
@lenkan
Copy link
Collaborator Author

lenkan commented May 5, 2024

Accidentally deleted the branch on my fork. Did not intend to close the PR.

@lenkan lenkan reopened this May 5, 2024
@rodolfomiranda rodolfomiranda merged commit 014b2bc into WebOfTrust:main May 9, 2024
6 checks passed
@lenkan lenkan deleted the fix-number-constructor branch May 17, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review usage of Number constructor for parsing to number
2 participants