chore: implement typings in ending module #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 83.93% 83.84% -0.10%
==========================================
Files 48 48
Lines 4257 4258 +1
Branches 1051 1057 +6
==========================================
- Hits 3573 3570 -3
- Misses 656 660 +4
Partials 28 28 ☔ View full report in Codecov by Sentry. |
lenkan
force-pushed
the
chore-typings-ending
branch
from
93649e3
to
242c8d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation from #279, I fixed the typings for the end/ending.ts module.
Also split the tests up in to smaller tests to make it easier to follow what the module is doing. In that I added some more test cases that were missing.