Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDKDEV-1085: limit port range for webrtc peer connections #1403

Closed
wants to merge 1 commit into from
Closed

RDKDEV-1085: limit port range for webrtc peer connections #1403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,22 @@ rtc::scoped_refptr<webrtc::PeerConnectionInterface> LibWebRTCProvider::createPee
factoryAndThreads.signalingThread->Invoke<void>(RTC_FROM_HERE, [&]() {
auto basicPortAllocator = makeUniqueWithoutFastMallocCheck<cricket::BasicPortAllocator>(&networkManager, &packetSocketFactory);

// WEBRTC_PEER_PORT_RANGE defines from:to port range for peer connections, example WEBRTC_PEER_PORT_RANGE=6050:6055
char * portLimit = getenv("WEBRTC_PEER_PORT_RANGE");
if (portLimit) {
std::string min, max;
std::istringstream iss(portLimit);
if (std::getline(iss, min, ':') && std::getline(iss, max, ':')) {
char * endPtrMin;
char * endPtrMax;
long portMin = strtol(min.c_str(), &endPtrMin, 10);
long portMax = strtol(max.c_str(), &endPtrMax, 10);
if (*endPtrMin == '\0' && *endPtrMax == '\0' && portMin >= 0 && portMin <= USHRT_MAX && portMax >= 0 && portMax <= USHRT_MAX && portMin < portMax) {
basicPortAllocator->SetPortRange((int)portMin, (int)portMax);
}
}
}

basicPortAllocator->set_allow_tcp_listen(false);
portAllocator = WTFMove(basicPortAllocator);
});
Expand Down