RDKDEV-1086: allow to pass "stuns" locators #1404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the information found in the following tickets, comparisons and tests on PC Chrome and WPE2.38 and code review there are not available at all stuns implementation: https://issues.webrtc.org/issues/42225835 https://issues.webrtc.org/issues/42230379 https://issues.webrtc.org/issues/42227696 After check "stuns" locators are processed by libwebrtc library in the same way like "stun" ones (udp only protocol is used), we could now allow to pass such locators without exception. We could accept stuns locator, but the inernal implementation in libwebrtc would do stun via UDP requests for that.
|
@emutavchi , Could you please look at this PR as well? It is important to know effect on all use-cases. |
|
I don't understand the commit message. According to your findings, is stuns supported by libwebrtc or not? |
|
stuns is not supported in libwebrtc. libwebrtc is doing ordinary stun via UDP request in such case, proposal is to enable it like we have on PC Chrome implementation (that is doing in such case ordinary stun via UDP). |
|
Alright, thanks! I'll try to upstream this in WebKit/WebKit#33901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the information found in the following tickets, comparisons and tests on PC Chrome and WPE2.38 and code review there are not available at all stuns implementation:
https://issues.webrtc.org/issues/42225835
https://issues.webrtc.org/issues/42230379
https://issues.webrtc.org/issues/42227696
After check "stuns" locators are processed by libwebrtc library in the same way like "stun" ones (udp only protocol is used), we could now allow to pass such locators without exception.
We could accept stuns locator, but the inernal implementation in libwebrtc would do stun via UDP requests for that.